Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getLastError() API to MultiProtocolJSONClient #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add getLastError() API to MultiProtocolJSONClient #353

wants to merge 2 commits into from

Commits on Jun 28, 2024

  1. Revert commits breaking API and binary OCPP 1.6 passwords 

    These commits were based on a misunderstanding of the OCPP-J 1.6
specification, which clearly states that the password is a byte sequence
and not a string:

Revert "More password fixes."

This reverts commit fb5d0fb.

Revert "Fix password decoding."

This reverts commit cf20205.

Revert "Recommended by 1.6 spec is a 20 byte (40 chars) key."

This reverts commit f7b92a3.

This commit breaks the API, because the behaviour of the method is
changed to return the last configuration instead of the default
configuration:

Revert "A single instace, otherwise a static get() method makes no sense."

This reverts commit 953f50b.
    @robert-s-ubi
    robert-s-ubi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    63fe226 View commit details
    Browse the repository at this point in the history

  2. Add getLastError() API to MultiProtocolJSONClient 

    To allow determining the cause of a disconnection, add a new API to
MultiProtocolJSONClient to retrieve the Exception passed from the
WebSocket library in the onError() callback.

This is required to allow logging the OCPP 2.0.1 Security Events
"InvalidTLSVersion" and "InvalidTLSCipherSuite", by examining the type
of Exception and its message string.
    @robert-s-ubi
    robert-s-ubi committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7904a1f View commit details
    Browse the repository at this point in the history