Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiagnosticsStatusNotification support. #38

Merged
merged 1 commit into from
Apr 16, 2018

Conversation

sumlin
Copy link
Contributor

@sumlin sumlin commented Apr 15, 2018

No description provided.

@coveralls
Copy link

coveralls commented Apr 15, 2018

Coverage Status

Coverage decreased (-0.2%) to 57.094% when pulling 505545f on sumlin:master into 72e5393 on ChargeTimeEU:master.

@codecov-io
Copy link

codecov-io commented Apr 15, 2018

Codecov Report

Merging #38 into master will decrease coverage by 0.16%.
The diff coverage is 44.73%.

@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
- Coverage     54.82%   54.65%   -0.17%     
- Complexity      651      660       +9     
============================================
  Files           151      155       +4     
  Lines          2302     2340      +38     
  Branches        152      155       +3     
============================================
+ Hits           1262     1279      +17     
- Misses          984     1004      +20     
- Partials         56       57       +1

Copy link
Member

@TVolden TVolden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. It's clean and easy to read. I'll check it against the specifications before I approve.

*
* MIT License
*
* Copyright (C) 2016 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change this to your own name and email.

*
* MIT License
*
* Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be your name and email.


/*
ChargeTime.eu - Java-OCA-OCPP
Copyright (C) 2015-2016 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate copyright.


MIT License

Copyright (C) 2016-2018 Thomas Volden
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be your name and email.

*
* MIT License
*
* Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be your name and email.


MIT License

Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be your name and email.


@Override
public int hashCode() {
return 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 5?

Copy link
Contributor Author

@sumlin sumlin Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? :D It just has to be different between other confirmations.


MIT License

Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be your name and email.


MIT License

Copyright (C) 2016-2018 Thomas Volden <tv@chargetime.eu>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be your name and email.

@sumlin sumlin force-pushed the master branch 2 times, most recently from 8645cbc to 9a7b077 Compare April 16, 2018 07:55
@TVolden TVolden merged commit 9e67a71 into ChargeTimeEU:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants