0.5 json stable under load #45
Conversation
…anage traffic for mobile connections) Server/client links are reset after server/client is closed Communicator logic to detect offline case relies on the closed flag Cosmetics
Session id added to session, getter added to ISession Stack trace omitted for logging not connected exception Cosmetics
NotConnectedException is thrown if session is not found while trying to send request to a client UUID belongs to session To simplify code Draft_6455 from the WebScoket implementation is used instead of self-made draft Feauture repos are logged on start with info level Log messages with debug level added to WebTransmitter on open/close/error events Cosmetics
… to license conditions
- backward compatibility of exposed API preserved - symmetric implementation for server and client - fail-fast for server/client builders for WSS not initialized with SSLContext/SSLSocketFactory - More explanatory exception for scheme and configuration mismatch for client than just NPE
WssFactoryBuilder and WssSocketBuilder now expose only the minimum required API
# Conflicts: # ocpp-v1_6/src/main/java/eu/chargetime/ocpp/JSONServer.java
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
============================================
- Coverage 51.09% 47.95% -3.14%
+ Complexity 673 664 -9
============================================
Files 157 156 -1
Lines 2558 2696 +138
Branches 180 194 +14
============================================
- Hits 1307 1293 -14
- Misses 1183 1335 +152
Partials 68 68 |
|
@sumlin I am trying to avoid to spend double effort making tests for not yet synchronized codebase. I tried to create pull requests in a way to add functionality incrementally to make it easier to merge. Once we are in sync I will migrate tests (which I already have done for standalone parts like utilities). |
| private static final Logger logger = LoggerFactory.getLogger(JSONClient.class); | ||
|
|
||
| public final Draft draftOcppOnly = | ||
| new Draft_6455(Collections.emptyList(), |
There was a problem hiding this comment.
Should be initiated in composite root (read the constructor).
There was a problem hiding this comment.
Initialization moved to constructor.
| private static final Logger logger = LoggerFactory.getLogger(JSONServer.class); | ||
|
|
||
| public final Draft draftOcppOnly = | ||
| new Draft_6455(Collections.emptyList(), |
There was a problem hiding this comment.
Should be initiated in composite root (read the constructor).
There was a problem hiding this comment.
Initialization moved to constructor.
|
The IC shows a compile issue: |
|
|
||
| import javax.net.ssl.SSLContext; |
There was a problem hiding this comment.
Reverting the external API changes makes this line necessary again. A merge problem. :)
There was a problem hiding this comment.
That's true. Fixed.
No description provided.