-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FirmwareStatusNotification support. #48
Add FirmwareStatusNotification support. #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
============================================
- Coverage 54.65% 54.47% -0.19%
- Complexity 660 667 +7
============================================
Files 155 159 +4
Lines 2340 2381 +41
Branches 155 158 +3
============================================
+ Hits 1279 1297 +18
- Misses 1004 1026 +22
- Partials 57 58 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only some minor java docs comments.
/** | ||
* This contains the status. | ||
* | ||
* @return connector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should change the docs to match the actual return type.
} | ||
|
||
/** | ||
* This contains the status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write: "This contains the progress status of the firmware installation."
- well actually, I steal these texts from the spec (shh)
} | ||
|
||
/** | ||
* Required. This contains the identifier of the status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write: "Required. This contains the progress status of the firmware installation."
(same as the spec)
/** | ||
* Required. This contains the identifier of the status. | ||
* | ||
* @param status FirmwareStatus, value != 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't really set a enum to 0? Applies to the next line too, I guess.
No description provided.