0.5 test coverage for utilities #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2018 11:45
Stopwatch updated to provide better interface to tests Tests for new utilities MoreObjects and Stopwatch created
|
It looks like the API changes has made some merge conflicts. Can you resolve them? |
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
============================================
+ Coverage 47.63% 52.71% +5.08%
- Complexity 682 710 +28
============================================
Files 164 164
Lines 2792 2796 +4
Branches 201 201
============================================
+ Hits 1330 1474 +144
+ Misses 1392 1241 -151
- Partials 70 81 +11 |
|
Merged from upstream. Should be ok. |
|
I also checked the ones for @sumlin. Seems nothing to do with API - rather formatting issue (something with line endings or spaces). |
|
Thank you, @eupakhomov :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the new utilities.