Refactor benchmark code and add more counters #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoeTerrier
force-pushed
the
benchmark-extended
branch
2 times, most recently
from
a501c39
to
392260c
Compare
CharlyCst
requested changes
Aug 8, 2024
| .align 4 | ||
| .global _start | ||
| _start: | ||
| csrw mie, 0x1 // Dummy instruction to exit firmware |
There was a problem hiding this comment.
What is this instruction doing? It sets bit 0 in mie but why do we need that?
There was a problem hiding this comment.
It's not requiered, but it result in a firmware exit: it's to show that the exit counter works :)
Maybe I can add an assertion to really check that the counter is set to 1 or remove this if it's useless here.
CharlyCst
previously approved these changes
Aug 8, 2024
Comment on lines
+157
to
+161
| for counter in [ | ||
| IntervalCounter::ExecutionTime, | ||
| IntervalCounter::InstructionRet, | ||
| ] | ||
| .map(Either::IntervalCounter) |
There was a problem hiding this comment.
Wow I didn't know we could do that in Rust, thanks for the trick :)
That implies that Either::IntervalCounter is a function, which is cool.
Code is refactored to make it easier to add a counter. Two type of counters: first one is basic counters with purpose of counting occurences of events. The second one aims to measure difference beetween two events. The counters shares many properties that are grouped under the Either enum. Other properties are recorded like number of world switches or firmware exits.
This commit adds a new benchmark ecall (FID number 3) to Miralis which prints the collected statistics. Because it can be helpful to use this functionality directly from the payload (e.g. Linux) this commit also make it possible to execute some of the Miralis ecalls from the payload.
Two new firmware to test benchmark ecall (FID number 3) from firmware and ecall from payload.
CharlyCst
force-pushed
the
benchmark-extended
branch
from
55a856e
to
99c601a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is refactored to make it easier to add a counter. Two type of counters: first one is basic counters yith purpose of counting occurences of events. The second one aims to measure difference beetween two events.
The counters shares many properties that are grouped under the Either enum.
Other properties are recorded like number of world switches or firmware exits.
Related to #125.