Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support feature flags usage #557

Merged
merged 18 commits into from
Jul 27, 2023
Merged

Support feature flags usage #557

merged 18 commits into from
Jul 27, 2023

Conversation

hmmachadocx
Copy link
Contributor

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Support feature flags usage
Handle PACKAGE_ENFORCEMENT_ENABLED usage

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

  • I have added documentation for new/changed functionality in this PR (if applicable).
  • I have updated the CLI help for new/changed functionality in this PR (if applicable).
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used

pedrompflopes and others added 5 commits May 3, 2023 12:30
…ero results

- Assign resolving module type to package manager if resolving module type is empty or doesn't exist in the map;
… wrap JWT enforcement with feature flag

- Support feature flags usage;
- Handle PACKAGE_ENFORCEMENT_ENABLED usage
@pedrompflopes pedrompflopes requested review from a team, tiagobcx and igorlombacx and removed request for a team July 18, 2023 18:43
@github-actions
Copy link

github-actions bot commented Jul 18, 2023

Logo
Checkmarx One – Scan Summary & Details654f7204-9188-4633-a09c-34ed1f209a5b

No New Or Fixed Issues Found

… wrap JWT enforcement with feature flag

- Remove payload property
… wrap JWT enforcement with feature flag

- Fix lint
… wrap JWT enforcement with feature flag

- Fix lint
… wrap JWT enforcement with feature flag

- Fix unit tests
… wrap JWT enforcement with feature flag

- Fix lint
… wrap JWT enforcement with feature flag

- Fix integration tests
… wrap JWT enforcement with feature flag

- Get flags for a specific tenant
… wrap JWT enforcement with feature flag

- Update FeatureFlags map with default values in case it does not exist in all flags response
… wrap JWT enforcement with feature flag

- Fix lint
… wrap JWT enforcement with feature flag

- Move tenant id handling inside feature-flags-http.go so that we can mock it in unit tests
@pedrompflopes pedrompflopes self-requested a review July 26, 2023 08:59
tiagobcx
tiagobcx previously approved these changes Jul 26, 2023
# Conflicts:
#	cmd/main.go
#	internal/commands/root.go
#	internal/commands/root_test.go
#	internal/params/binds.go
#	internal/params/keys.go
#	test/integration/util_command.go
@pedrompflopes pedrompflopes merged commit 8ec775e into main Jul 27, 2023
6 checks passed
@pedrompflopes pedrompflopes deleted the feature/jwt_enforcement branch July 27, 2023 10:55
thtri pushed a commit to thtri/ast-cli that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants