Print policy violations only if any rule was violated (AST-66024)

internal/commands/result.go

@@ -791,13 +791,22 @@ func writeConsoleSummary(summary *wrappers.ResultSummary, featureFlagsWrapper wr
 }
 
 func printPoliciesSummary(summary *wrappers.ResultSummary) {
-	fmt.Printf(tableLine + "\n")
-	if summary.Policies.BreakBuild {
-		fmt.Printf("            Policy Management Violation - Break Build Enabled:                     \n")
-	} else {
-		fmt.Printf("            Policy Management Violation:                     \n")
-	}
+	hasViolations := false
 	if len(summary.Policies.Policies) > 0 {
+		for _, policy := range summary.Policies.Policies {
+			if len(policy.RulesViolated) > 0 {
+				hasViolations = true
+				break
+			}
+		}
+	}
+	if hasViolations {
+		fmt.Printf(tableLine + "\n")
+		if summary.Policies.BreakBuild {
+			fmt.Printf("            Policy Management Violation - Break Build Enabled:                     \n")
+		} else {
+			fmt.Printf("            Policy Management Violation:                     \n")
+		}
 		for _, police := range summary.Policies.Policies {
 			if len(police.RulesViolated) > 0 {
 				fmt.Printf("              Policy: %s | Break Build: %t | Violated Rules: ", police.Name, police.BreakBuild)
@@ -807,8 +816,8 @@ func printPoliciesSummary(summary *wrappers.ResultSummary) {
 			}
 			fmt.Printf("\n")
 		}
+		fmt.Printf("\n")
 	}
-	fmt.Printf("\n")
 }
 
 func printAPIsSecuritySummary(summary *wrappers.ResultSummary) {

internal/commands/result_test.go

@@ -3,6 +3,7 @@
 package commands
 
 import (
+	"bytes"
 	"encoding/json"
 	"fmt"
 	"io"
@@ -1138,3 +1139,31 @@ func createEmptyResultSummary() *wrappers.ResultSummary {
 		},
 	}
 }
+func TestPrintPoliciesSummary_WhenNoRolViolated_ShouldNotContainPolicyViolation(t *testing.T) {
+	summary := &wrappers.ResultSummary{
+		Policies: &wrappers.PolicyResponseModel{
+			Status: "Success",
+			Policies: []wrappers.Policy{
+				{
+					RulesViolated: []string{},
+				},
+			},
+			BreakBuild: false,
+		},
+	}
+	r, w, _ := os.Pipe()
+	old := os.Stdout
+	os.Stdout = w
+
+	printPoliciesSummary(summary)
+
+	w.Close()
+	os.Stdout = old
+
+	var buf bytes.Buffer
+	if _, err := io.Copy(&buf, r); err != nil {
+		t.Fatalf("failed to copy output: %v", err) // Handle the error if io.Copy fails
+	}
+	output := buf.String()
+	assert.Assert(t, !strings.Contains(output, "Policy Management Violation "), "Output should not contain 'Policy Management Violation'")
+}

internal/commands/util/pr.go

@@ -283,6 +283,9 @@ func policiesToPrPolicies(policy *wrappers.PolicyResponseModel) []wrappers.PrPol
 	var prPolicies []wrappers.PrPolicy
 	if policy != nil {
 		for _, policy := range policy.Policies {
+			if len(policy.RulesViolated) == 0 {
+				continue
+			}
 			prPolicy := wrappers.PrPolicy{}
 			prPolicy.Name = policy.Name
 			prPolicy.BreakBuild = policy.BreakBuild

internal/commands/util/pr_test.go

@@ -37,3 +37,10 @@ func TestIfScanRunning_WhenScanDone_ShouldReturnFalse(t *testing.T) {
 	scanRunning, _ := isScanRunningOrQueued(scansMockWrapper, "ScanNotRunning")
 	asserts.False(t, scanRunning)
 }
+
+func TestPRDecorationGithub_WhenNoViolatedPolicies_ShouldNotReturnPolicy(t *testing.T) {
+	prMockWrapper := &mock.PolicyMockWrapper{}
+	policyResponse, _, _ := prMockWrapper.EvaluatePolicy(nil)
+	prPolicy := policiesToPrPolicies(policyResponse)
+	asserts.True(t, len(prPolicy) == 0)
+}