Added errorhandling to lookup API

plugins/lookup/folder.py

@@ -62,6 +62,7 @@
 
 import json
 
+from ansible.errors import AnsibleError
 from ansible.plugins.lookup import LookupBase
 from ansible_collections.checkmk.general.plugins.module_utils.lookup_api import (
     CheckMKLookupAPI,
@@ -92,6 +93,11 @@ def run(self, terms, variables, **kwargs):
             response = json.loads(
                 api.get("/objects/folder_config/" + term.replace("/", "~"))
             )
+            if "code" in response:
+                raise AnsibleError(
+                    "Received error for %s - %s: %s"
+                    % (response["url"], response["code"], response["msg"])
+                )
             ret.append(response.get("extensions"))
 
         return ret

plugins/lookup/folders.py

@@ -96,6 +96,7 @@
 
 import json
 
+from ansible.errors import AnsibleError
 from ansible.plugins.lookup import LookupBase
 from ansible_collections.checkmk.general.plugins.module_utils.lookup_api import (
     CheckMKLookupAPI,
@@ -134,7 +135,11 @@ def run(self, terms, variables, **kwargs):
                 api.get("/domain-types/folder_config/collections/all", parameters)
             )
 
+            if "code" in response:
+                raise AnsibleError(
+                    "Received error for %s - %s: %s"
+                    % (response["url"], response["code"], response["msg"])
+                )
             ret.append(response.get("value"))
-            # ret.append([{"name": "debug %s" % term, "extensions": { "attributes": { "tag_criticality": "prod" } } }])
 
         return ret

plugins/lookup/host.py

@@ -68,6 +68,7 @@
 
 import json
 
+from ansible.errors import AnsibleError
 from ansible.plugins.lookup import LookupBase
 from ansible_collections.checkmk.general.plugins.module_utils.lookup_api import (
     CheckMKLookupAPI,
@@ -103,6 +104,12 @@ def run(self, terms, variables, **kwargs):
             api_endpoint = "/objects/host_config/" + term
 
             response = json.loads(api.get("/objects/host_config/" + term, parameters))
+
+            if "code" in response:
+                raise AnsibleError(
+                    "Received error for %s - %s: %s"
+                    % (response["url"], response["code"], response["msg"])
+                )
             ret.append(response.get("extensions"))
 
         return ret

plugins/lookup/hosts.py

@@ -66,6 +66,7 @@
 
 import json
 
+from ansible.errors import AnsibleError
 from ansible.plugins.lookup import LookupBase
 from ansible_collections.checkmk.general.plugins.module_utils.lookup_api import (
     CheckMKLookupAPI,
@@ -99,6 +100,11 @@ def run(self, terms, variables, **kwargs):
         response = json.loads(
             api.get("/domain-types/host_config/collections/all", parameters)
         )
+        if "code" in response:
+            raise AnsibleError(
+                "Received error for %s - %s: %s"
+                % (response["url"], response["code"], response["msg"])
+            )
         ret.append(response.get("value"))
 
         return ret

plugins/lookup/version.py

@@ -57,6 +57,7 @@
 
 import json
 
+from ansible.errors import AnsibleError
 from ansible.plugins.lookup import LookupBase
 from ansible_collections.checkmk.general.plugins.module_utils.lookup_api import (
     CheckMKLookupAPI,
@@ -81,5 +82,11 @@ def run(self, terms, variables, **kwargs):
             )
 
             response = json.loads(api.get("/version"))
+
+            if "code" in response:
+                raise AnsibleError(
+                    "Received error for %s - %s: %s"
+                    % (response["url"], response["code"], response["msg"])
+                )
             ret.append(response.get("versions", {}).get("checkmk"))
         return ret

plugins/module_utils/lookup_api.py

@@ -8,10 +8,20 @@
 
 __metaclass__ = type
 
+import json
+
 from ansible.module_utils.common.text.converters import to_text
+from ansible.module_utils.six.moves.urllib.error import HTTPError, URLError
 from ansible.module_utils.six.moves.urllib.parse import urlencode
 from ansible.module_utils.urls import open_url
 
+HTTP_ERROR_CODES = {
+    400: "Bad Request: Parameter or validation failure.",
+    403: "Forbidden: Configuration via Setup is disabled.",
+    404: "Not Found: The requested object has not been found.",
+    406: "Not Acceptable: The requests accept headers can not be satisfied.",
+}
+
 
 class CheckMKLookupAPI:
     """Base class to contact a Checkmk server for ~Lookup calls"""
@@ -35,9 +45,22 @@ def get(self, endpoint="", parameters=None):
             url = "%s?%s" % (url, urlencode(parameters))
 
         response = ""
-        raw_response = open_url(
-            url, headers=self.headers, validate_certs=self.validate_certs
-        )
-        response = to_text(raw_response.read())
+
+        try:
+            raw_response = open_url(
+                url, headers=self.headers, validate_certs=self.validate_certs
+            )
+            response = to_text(raw_response.read())
+        except HTTPError as e:
+            if e.code in HTTP_ERROR_CODES:
+                response = json.dumps(
+                    {"code": e.code, "msg": HTTP_ERROR_CODES[e.code], "url": url}
+                )
+            else:
+                response = json.dumps({"code": e.code, "msg": e.reason, "url": url})
+        except URLError as e:
+            response = json.dumps({"code": 0, "msg": str(e), "url": url})
+        except Exception as e:
+            response = json.dumps({"code": 0, "msg": str(e), "url": url})
 
         return response