Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redirect option for activation endpoint #479

Merged

Conversation

Max-checkmk
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • Redirect option is always set to false in the activation endpoint.
  • In the agent role we have a fixed wait time of 30sec after activating changes

What is the new behavior?

  • It's now possible to set redirect to true
  • In the agent role the activation handler has redirect set to true, so there's no need to wait anymore

Other information

Even with redirect set to true, there is no need to handle the redirect (like with service discovery endpoint).
This works without further changes.

@Max-checkmk Max-checkmk added enhancement New feature or request role:agent This affects the agent role module:activation This affects the activation module labels Nov 22, 2023
@Max-checkmk Max-checkmk self-assigned this Nov 22, 2023
@github-actions github-actions bot removed the role:agent This affects the agent role label Nov 22, 2023
@robin-checkmk robin-checkmk mentioned this pull request Nov 23, 2023
7 tasks
@robin-checkmk robin-checkmk added the release:4.0.0 Affects the mentioned release. label Nov 24, 2023
@robin-checkmk
Copy link
Member

As discussed outside of GitHub, we will clarify some things internally before moving this forward.
Technically it looks fine, we just want to check, that there are no side effects.
Once that has been cleared, we can merge this for release 4.0.0.

@robin-checkmk robin-checkmk changed the base branch from devel to hackathon/2023-12-01 December 1, 2023 11:43
@robin-checkmk robin-checkmk merged commit 2042417 into hackathon/2023-12-01 Dec 1, 2023
7 checks passed
@robin-checkmk robin-checkmk deleted the improve_activation_with_redirect branch December 1, 2023 12:52
@robin-checkmk robin-checkmk mentioned this pull request Dec 1, 2023
7 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request module:activation This affects the activation module release:4.0.0 Affects the mentioned release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants