Enable Collection for Checkmk 2.3.0 #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection-checkmk.general into build/checkmk-2-3-support
github-actions
bot
added
documentation
….general into build/checkmk-2-3-support
robin-checkmk
changed the title
robin-checkmk
changed the title
Due to this, we can move away from the dedicated Vagrant box as well.
…e-collection-checkmk.general into build/checkmk-2-3-support
Make discovery module 2.3 ready
|
The failing tests are mostly not relevant, except for the rules, but those errors are already fixed in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number:
e.g. #1What is the new behavior?
Other information
ToDos
rulemodule is broken with Checkmk 2.3.0. Former versions work.discoverymodule is a bad shape when it comes to discovery modes. We need to align it with the current state of the REST API, while making sure it stays backwards compatible.