[DOC] Updating exemple for version lookup #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 3.4.0
Update changelogs and docs
Release 4.0.0
Release 4.0.0 Addendum
Update changelogs and docs
Release 4.0.1
Bump collection version.
Update changelogs and docs
Build related changes
Release 4.1.0
Update changelogs and docs
Release `4.2.0`
Update changelogs and docs
Release 4.3.0
Release 4.3.1
Update changelogs and docs upon release
github-actions
bot
added
the
documentation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA. |
|
Nice catch, thanks @kirby0025! |
robin-checkmk
approved these changes
Mar 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an upgrade or a fresh install of the component, I started having errors about server_url setting not defined for the lookup. I realized the documentation was not up-to-date with the lookup's arguments.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Current exemple reflects the old behaviour of the lookup where server_url was only one field.
Old working exemple :
cmk_agent_version: "{{ lookup('checkmk.general.version', cmk_url+cmk_site, automation_user='automation', automation_secret=cmk_automation_password)}}"What is the new behavior?
New exemple reflects the actual behaviour of the lookup.
New working exemple :
cmk_agent_version: "{{ lookup('checkmk.general.version', server_url=cmk_url, site=cmk_site, automation_user='automation', automation_secret=cmk_automation_password)}}"