Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sanity compile fails #590

Closed
wants to merge 2 commits into from
Closed

Fix/sanity compile fails #590

wants to merge 2 commits into from

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Apr 10, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Sanity Checks for Python 3.12 are failing in the "compile" step.

What is the new behavior?

  • Sanity checks are working fine.

Other information

@lgetwan
Copy link
Contributor Author

lgetwan commented Apr 10, 2024

After solving the "invalid escape sequence" issue, a whole bunch of new issues are found by the sanity check.

Looks like the guy from https://github.com/gdraheim/docker-systemctl-replacement has to make his project Python 3.12 compatible.

I'll close this PR.

@lgetwan lgetwan closed this Apr 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
@robin-checkmk
Copy link
Member

@lgetwan this is actually a false positive and I thought I suppressed the messages, as Ansible should not care about those files. But it is kind of tricky, and I have to review, why the behavior changed again. But I will take care of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants