Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve idempotency of the registration tasks in the agent #615

Merged
merged 22 commits into from
Jun 14, 2024

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Jun 6, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Both registrations, agent and updater were carried out by the agent role every time causing a change, even if the host was already successfully registered. While this does not break anything (given the configuration is sound), it is an inconvenience.

What is the new behavior?

The agent role now checks, whether any of the registrations actually need to be performed.

Other information

This change should be reviewed carefully, as the approaches chosen might not be ideal, or at least not without risks.
However, the worst case perceivable would be an unnecessary registration, we should not see anything actually break.

@robin-checkmk robin-checkmk self-assigned this Jun 6, 2024
@robin-checkmk robin-checkmk changed the base branch from main to devel June 6, 2024 22:55
@robin-checkmk robin-checkmk changed the base branch from devel to feature/mark-internal-vars June 6, 2024 22:55
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2024
@github-actions github-actions bot added the module:user This affects the user module label Jun 7, 2024
@robin-checkmk robin-checkmk added role:agent This affects the agent role and removed module:user This affects the user module labels Jun 10, 2024
@robin-checkmk robin-checkmk marked this pull request as ready for review June 10, 2024 15:47
@robin-checkmk robin-checkmk mentioned this pull request Jun 13, 2024
7 tasks
@github-actions github-actions bot added role:server This affects the server role module:rule This affects the rule module module:user This affects the user module labels Jun 13, 2024
Base automatically changed from feature/mark-internal-vars to devel June 14, 2024 13:21
@robin-checkmk robin-checkmk merged commit 4f35237 into devel Jun 14, 2024
9 checks passed
@robin-checkmk robin-checkmk deleted the feature/agent-improve-idempotency branch June 14, 2024 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation module:rule This affects the rule module module:user This affects the user module role:agent This affects the agent role role:server This affects the server role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants