Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: return rule id for existing rule #665

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix: return rule id for existing rule #665

merged 2 commits into from
Sep 30, 2024

Conversation

msekania
Copy link
Contributor

returns content (includes rule id) field for existing and not modified rules

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #663

What is the new behavior?

  • return content, http_code for the case when rule exists and changes are not required

Other information

@github-actions github-actions bot added the module:rule This affects the rule module label Sep 26, 2024
@msekania msekania changed the title Fix: return rule id for existing rule #663 Fix: return rule id for existing rule Sep 26, 2024
lgetwan
lgetwan approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. I also successfully tested the new function.
Thanks for implementing this, Michael!

@robin-checkmk robin-checkmk added the release:5.3.0 Affects the mentioned release. label Sep 30, 2024
@robin-checkmk robin-checkmk merged commit 862a95b into Checkmk:devel Sep 30, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lgetwan lgetwan lgetwan approved these changes

Assignees

@lgetwan lgetwan

Labels
module:rule This affects the rule module release:5.3.0 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msekania @lgetwan @robin-checkmk