New clvm generator api #9645
Merged
New clvm generator api #9645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidn
force-pushed
the
new-clvm-generator-api
branch
2 times, most recently
from
b4dff31
to
d053ae5
Compare
|
This pull request fixes 2 alerts when merging d053ae5 into 659f4f4 - view on LGTM.com fixed alerts:
|
arvidn
force-pushed
the
new-clvm-generator-api
branch
2 times, most recently
from
0a87589
to
dc2ad48
Compare
arvidn
commented
Jan 11, 2022
| if r.seconds_relative > 0: | ||
| add_int_cond(conditions, ConditionOpcode.ASSERT_SECONDS_RELATIVE, r.seconds_relative) | ||
| for cc in r.create_coin: | ||
| if cc[2] == b"": |
There was a problem hiding this comment.
this is a slight difference. the new clvm_rs API always returns a 3-tuple with the last element being bytes. If there is no hint, the bytes is empty. However, previously, an empty atom was a valid hint, distinct from no hint at all.
Since hints aren't consensus critical, I don't think this really matters, but it meant I had to change the test_rom.py below.
arvidn
force-pushed
the
new-clvm-generator-api
branch
from
dc2ad48
to
f0efdd3
Compare
richardkiss
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the more compact return value from
run_generator2()and converts it to our internal (more verbose) conditions format.