-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.11 #16
Python 3.11 #16
Conversation
iirc, there was also some other trick @richardkiss had to pull to get |
Note that a single binary is built for all python versions for a given platform. Because of this, I don't think it's actually necessary to check all versions of python. |
As for the Windows-specific stuff, I'd recommend looking at how the windows build works elsewhere. Ideally, we should serialize these process – create a wheel, export it as an artifact, then import that artifact by dependent testing and benchmark actions. This would let us build the wheel just once, and also test just that particular binary. It would take a Github Actions wizard to do this for sure, but it's the right way. |
I've done exactly that sequence in other projects and have commented on it at various points here, but I haven't taken it on myself to actually switch over here. Let alone for a dozen or whatever repos... https://github.com/altendky/ciborg/actions/runs/363450564 is an example. As to testing more Python versions, I personally default to testing the matrix we claim to support, until it gets onerous. I think that our support repos like this are low enough traffic and the tests are quick enough that the CI runtime overhead is negligible. In some sense there is added overhead in the CI setup complexity, but if we maintain it then we get the benefit of consistency across projects which is an alternative benefit. |
A comment here... I think ideally you want to build the |
Draft for: