This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Changes to sexp.rs's handling of termlist and clone optimisations #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20230814 termist proposal
|
The argument people make with using the associated function form of Rc::clone isn't that it's cheaper (it's actually the same as cloning an Rc), but that it makes clear that it's just an Rc clone (not cloning the object), which I can be on board with. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch simplifies the parsing of termlist in pre-form assembling, and replaces calls to
.clone()on Rc objects with theRc::clone()call which is more memory efficient.