Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add output with the number of deleted package versions #35

Closed
wants to merge 1 commit into from
Closed

Add output with the number of deleted package versions #35

wants to merge 1 commit into from

Conversation

mering
Copy link
Contributor

@mering mering commented Nov 7, 2023

Use this output also to improve tests

@Chizkiyahu
Copy link
Owner

@mering
Is fail in https://github.com/Chizkiyahu/delete-untagged-ghcr-action/actions/runs/6785873604
I fix in 22e65b4
still fails in https://github.com/Chizkiyahu/delete-untagged-ghcr-action/actions/runs/6786034181

@mering
Copy link
Contributor Author

mering commented Nov 7, 2023

Sorry, rebase error after I had to make changes in #33 (I only tested it with the original version of it). Should be fixed now.

@mering
Copy link
Contributor Author

mering commented Nov 9, 2023

Could you please have another look?

@Chizkiyahu
Copy link
Owner

Could you please have another look?
is fail
https://github.com/Chizkiyahu/delete-untagged-ghcr-action/actions/runs/6810990584/job/18520406549

@mering
Add output with the number of deleted package versions
3dc5fa6 
Use this output also to improve tests
@mering
Copy link
Contributor Author

mering commented Nov 9, 2023

It seems that it is not possible to use this action to clean up in the beginning as it fails when there are no packages (which is the usual step).

I tested it on my repo and the latest version works there.

@Chizkiyahu
Copy link
Owner

You can add param ignore pkg not exist
And ignore this error in the code

@mering
Copy link
Contributor Author

mering commented Nov 9, 2023

You can add param ignore pkg not exist And ignore this error in the code

Let's do this in a separate PR. The functionality of this PR in itself is valuable as is.

@Chizkiyahu
Copy link
Owner

@mering
is not a bug in your code
https://github.com/orgs/community/discussions/75302

@Chizkiyahu Chizkiyahu mentioned this pull request Nov 12, 2023
Merged
@Chizkiyahu
Copy link
Owner

@mering
merged in #36

@Chizkiyahu Chizkiyahu closed this Nov 12, 2023
@mering mering deleted the check-num-deleted-output branch November 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mering @Chizkiyahu