Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Person List Columns Configurable #7147

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Make Person List Columns Configurable #7147

merged 1 commit into from
Sep 17, 2024

Conversation

bigtigerku
Copy link
Contributor

@bigtigerku bigtigerku commented Sep 16, 2024 •
edited
Loading

Description & Issue number it closes

#7021
I will make similar change for family list later.

Screenshots (if appropriate)

Before

Screenshot 2024-09-15 at 11 10 11 PM

Config Change

Hide Home Phone and Cell Phone.
Screenshot 2024-09-15 at 11 11 18 PM

After

Screenshot 2024-09-15 at 11 23 49 PM

How to test the changes?

See the above screenshots

Click View Active People after changing Admin/ Edit General Settings / People Setup / sPersonListColumns

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner September 16, 2024 06:33
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team September 16, 2024 06:33
@DAcodedBEAT DAcodedBEAT added this to the vNext (5.10.1) milestone Sep 17, 2024
@DAcodedBEAT DAcodedBEAT merged commit 3e7c791 into ChurchCRM:master Sep 17, 2024
5 checks passed
@DAcodedBEAT DAcodedBEAT added enhancement UI php Pull requests that update Php code labels Sep 19, 2024
@DAcodedBEAT DAcodedBEAT linked an issue Sep 21, 2024 that may be closed by this pull request
Feature request: Customize columns on View Active People/Families #7021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DAcodedBEAT DAcodedBEAT DAcodedBEAT approved these changes

@respencer respencer Awaiting requested review from respencer respencer is a code owner automatically assigned from ChurchCRM/developers

@DawoudIO DawoudIO Awaiting requested review from DawoudIO DawoudIO is a code owner automatically assigned from ChurchCRM/developers

@grayeul grayeul Awaiting requested review from grayeul grayeul is a code owner automatically assigned from ChurchCRM/developers

@MrClever MrClever Awaiting requested review from MrClever MrClever is a code owner automatically assigned from ChurchCRM/developers

Assignees
No one assigned
Labels
enhancement php Pull requests that update Php code UI
Projects
None yet
Milestone
vNext (5.10.1)
Development

Successfully merging this pull request may close these issues.

Feature request: Customize columns on View Active People/Families
2 participants
@bigtigerku @DAcodedBEAT