Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BGP policy augmentations missing for OC-RPOL model #102

Closed
111pontes opened this issue May 4, 2016 · 2 comments
Closed

BGP policy augmentations missing for OC-RPOL model #102

111pontes opened this issue May 4, 2016 · 2 comments
Labels

Comments

@111pontes
Copy link
Collaborator

BGP policy augmentations (https://git.io/vwdlH) missing for OC routing-policy APIs (https://git.io/vwdlK).

@111pontes 111pontes added the bug label May 4, 2016
@ghost ghost self-assigned this May 14, 2016
@ghost
Copy link

ghost commented May 14, 2016

The problem is showing up because the profile file we used to generate YDK 0.4.0 is not using the openconfig github repo to get the BGP models for some reason. The same problem existed in the 0.3.0 profile.

@ghost
Copy link

ghost commented May 16, 2016

The BGP policy augmentations are available in this github commit of OC BGP models. The 0.4.1 profile can be changed to use these newer models instead of the BGP models which were used for 0.4.0. Below is the diff of the profile file. This change will affect all the sample apps which used the oc bgp model.

--- profiles/ydk/ydk_0_4_0.json 2016-05-16 09:19:50.000000000 -0700
+++ profiles/ydk/ydk_0_4_1.json 2016-05-16 15:06:22.000000000 -0700
@@ -5,18 +5,6 @@
     "Copyright": "Cisco",

     "models": {
-   
-   "file": [
-       "profiles/ydk/yang/openconfig/bgp@2015-05-15.yang",
-       "profiles/ydk/yang/openconfig/bgp-multiprotocol@2015-05-15.yang",
-       "profiles/ydk/yang/openconfig/bgp-operational@2015-05-15.yang",
-       "profiles/ydk/yang/openconfig/bgp-types@2015-05-15.yang",
-       "profiles/ydk/yang/openconfig/oc-xr-mapping@2015-02-10.yang",
-       "profiles/ydk/yang/openconfig/policy-types@2015-05-15.yang",
-       "profiles/ydk/yang/openconfig/routing-policy@2015-05-15.yang",
-       "profiles/ydk/yang/ietf/ietf-interfaces-ext.yang"
-        ]
-    ,

    "_descr_git": "Each element on the list has details on git repositories to source models from, including commit ids and relative paths inside the repositories. If no commit id is specified, HEAD is taken. This is unwise. The nested dir and file references are interpreted the same way as specific dir and file references above.",
    "git": [
@@ -468,6 +456,19 @@
        "url": "https://github.com/openconfig/public.git",
        "commits": [
                    {
+                       "commitid": "b16616eb23cb459c96d7ebfce70b133cd58d56e3",
+                       "dir": [
+                               
+                               "release/models/bgp",
+                               "release/models/policy"
+                           ]                           
+            }
+            ]
+            },
+       {
+       "url": "https://github.com/openconfig/public.git",
+       "commits": [
+                   {
                        "commitid": "4ab22755c2484e893b2c2b6d88f800b8dd41bb09",
                        "dir": [

ghost pushed a commit that referenced this issue May 20, 2016
@ghost ghost closed this as completed May 25, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant