Clean up service/provider logging #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codec service logging now shows where the encode/decode operation starts and where it is completed. Also, the codec provider doesn't log an identity (object) any more. Logging the object reference wasn't particularly informative.
CRUD service logging now shows where an operation starts and where it is completed.
Executor service logging now shows where an execute_rpc operation starts and where it is completed.
Executor service now uses module name for the logger (__name__). Naming is consistent with the logger for the other services.
Brings consistency to logger names. All loggers now use the Python module name (__name__).
Disconnect message doesn't show port as 'None' when the default port (830) is being used. If port is left unspecified when the session is opened, logging doesn't try to specify the port explicitly when disconnecting.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve consistency in logging formatting and coverage across services and providers. Covers all services except NETCONF service.