Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update netconf session/service provider with timeout parameter #492 #424 #570

Merged
2 commits merged into from
Sep 23, 2017

Conversation

ylil93
Copy link
Contributor

@ylil93 ylil93 commented Sep 22, 2017

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2017

Codecov Report

Merging #570 into master will decrease coverage by <.01%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   79.15%   79.14%   -0.01%     
==========================================
  Files          91       91              
  Lines        9334     9338       +4     
  Branches     1286     1286              
==========================================
+ Hits         7388     7391       +3     
- Misses       1688     1689       +1     
  Partials      258      258
Impacted Files Coverage Δ
sdk/python/core/tests/test_sanity_levels.py 82.27% <100%> (ø) ⬆️
sdk/python/core/tests/test_utils.py 100% <100%> (ø) ⬆️
sdk/python/core/tests/test_netconf_operations.py 99.07% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_deviation_bgp.py 96.55% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_netconf.py 89.84% <100%> (ø) ⬆️
sdk/python/core/tests/test_on_demand.py 98.07% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_delete.py 99.52% <100%> (ø) ⬆️
...dk/python/core/tests/test_sanity_service_errors.py 92.07% <100%> (ø) ⬆️
sdk/python/core/tests/test_sanity_deviation.py 94.48% <100%> (ø) ⬆️
...hon/core/tests/test_sanity_type_mismatch_errors.py 87.77% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 691a56a...a39458e. Read the comment docs.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this change!

@ghost ghost merged commit 821d937 into CiscoDevNet:master Sep 23, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant