Added support for multiple entities for Go

.travis.yml

@@ -6,12 +6,11 @@ matrix:
   include:
     - os: linux
       dist: trusty
-      go: 1.8
       group: edge
     - os: osx
       osx_image: xcode7.3
       language: generic
-      go: 1.8
+      go: 1.9
     - env: DOCKER=true OS_TYPE=centos OS_VERSION=centos7 PYTHON_VERSION=2.7
     - env: DOCKER=true OS_TYPE=centos OS_VERSION=centos7 PYTHON_VERSION=3.6
     - env: DOCKER=true OS_TYPE=ubuntu OS_VERSION=xenial PYTHON_VERSION=2.7

sdk/cpp/core/src/path/netconf_session.cpp

@@ -489,8 +489,9 @@ static string get_filter_payload(path::Rpc & ydk_rpc)
 {
     auto entity = ydk_rpc.get_input_node().find("filter");
     if(entity.empty()){
-        YLOG_ERROR("Failed to get entity node.");
-        throw(YInvalidArgumentError{"Failed to get entity node"});
+        YLOG_WARN("Failed to get filter node for RPC; it then will be skipped.");
+        return string{};
+        //throw(YInvalidArgumentError{"Failed to get entity node"});
     }
 
     auto datanode = entity[0];
@@ -500,8 +501,9 @@ static string get_filter_payload(path::Rpc & ydk_rpc)
 static string get_netconf_payload(path::DataNode & input, const string &  data_tag, const string &  data_value)
 {
     path::Codec codec_service{};
-    input.create_datanode(data_tag, data_value);
-
+    if (data_tag != "filter" || data_value != "") {
+        input.create_datanode(data_tag, data_value);
+    }
     string payload{"<rpc xmlns=\"urn:ietf:params:xml:ns:netconf:base:1.0\">\n"};
     payload+=codec_service.encode(input, EncodingFormat::XML, true);
     payload+="</rpc>";

sdk/cpp/core/src/ydk.cpp

@@ -117,21 +117,23 @@ static ydk::EncodingFormat get_real_encoding(EncodingFormat encoding)
 {
     switch(encoding)
     {
-        case XML:
-            return ydk::EncodingFormat::XML;
         case JSON:
             return ydk::EncodingFormat::JSON;
+        case XML:
+        default:
+            return ydk::EncodingFormat::XML;
     }
 }
 
 static ydk::Protocol get_real_protocol(Protocol protocol)
 {
     switch(protocol)
     {
-        case Netconf:
-            return ydk::Protocol::netconf;
         case Restconf:
             return ydk::Protocol::restconf;
+        case Netconf:
+        default:
+            return ydk::Protocol::netconf;
     }
 }
 
@@ -187,16 +189,16 @@ static void handle_error(YDKState* state)
         state->error_type = YDK_MODEL_ERROR;
         handle_error_message(state, e.what());
     }
-    catch (const ydk::YError & e) {
-        state->error_type = YDK_ERROR;
+    catch(const ydk::path::YCodecError & e) {
+        state->error_type = YDK_CODEC_ERROR;
         handle_error_message(state, e.what());
     }
     catch(const ydk::path::YCoreError & e) {
         state->error_type = YDK_CORE_ERROR;
         handle_error_message(state, e.what());
     }
-    catch(const ydk::path::YCodecError & e) {
-        state->error_type = YDK_CODEC_ERROR;
+    catch (const ydk::YError & e) {
+        state->error_type = YDK_ERROR;
         handle_error_message(state, e.what());
     }
 }
@@ -869,6 +871,7 @@ LogLevel GetLoggingLevel(void)
 
         case spdlog::level::critical:
         case spdlog::level::err:
+        default:
             return ERROR;
     }
 }

sdk/cpp/tests/test_netconf_service.cpp

@@ -328,30 +328,3 @@ TEST_CASE("ietf_get_rpc")
         cout << "Exception while executing RPC: " << ex.what() << endl;
     }
 }
-
-TEST_CASE("get_config_openconfig_interfaces_and_bgp")
-{
-    path::Repository repo{TEST_HOME};
-    NetconfServiceProvider provider{repo, "127.0.0.1", "admin", "admin", 12022};
-    ydk::path::RootSchemaNode& schema = provider.get_session().get_root_schema();
-
-    std::shared_ptr<ydk::path::Rpc> read_rpc { schema.create_rpc("ietf-netconf:get") };
-
-    // filter
-    openconfig_interfaces::Interfaces interfaces_filter{};
-    openconfig_bgp::Bgp bgp_filter{};
-
-    std::string filter_string = get_xml_subtree_filter_payload(interfaces_filter, provider);
-    filter_string += "\n" + get_xml_subtree_filter_payload(bgp_filter, provider);
-
-    read_rpc->get_input_node().create_datanode("filter", filter_string);
-
-    auto read_result = (*read_rpc)(provider.get_session());
-    REQUIRE(read_result != nullptr);
-
-    // Print config
-    vector<shared_ptr<ydk::path::DataNode>> data_nodes = read_result->get_children();
-    for (auto dn : data_nodes) {
-        print_data_node(dn);
-    }
-}

sdk/go/README.md

@@ -14,7 +14,7 @@
 - [Docker](#docker)
 - [How to Install](#how-to-install)
   - [System Requirements](#system-requirements)
-  - [Installing](#installing)
+  - [Installing YDK](#installing-ydk)
 - [Documentation and Support](#documentation-and-support)
 - [Release Notes](#release-notes)
 
@@ -64,6 +64,16 @@ $ sudo yum install https://devhub.cisco.com/artifactory/rpm-ydk/0.7.1/libydk-0.7
 
 ```
 
+Golang
+
+The YDK requires Go version 1.9 or higher. If this is not the case, follow below installation steps. Make sure that environment variables GOROOT and GOPATH are properly set.
+```
+$ sudo wget https://storage.googleapis.com/golang/go1.9.2.linux-amd64.tar.gz &> /dev/null
+$ sudo tar -zxf  go1.9.2.linux-amd64.tar.gz -C /usr/local/
+$ export GOROOT="/usr/local/go"
+$ export PATH=$GOROOT/bin:$PATH
+```
+
 **Mac**  
 It is recommended to install [homebrew](http://brew.sh) and Xcode command line tools on your system before installing YDK-Go:
 ```
@@ -74,8 +84,14 @@ $ xcode-select --install
 $ curl -O https://devhub.cisco.com/artifactory/osx-ydk/0.7.1/libydk-0.7.1-Darwin.pkg
 $ sudo installer -pkg libydk-0.7.1-Darwin.pkg -target /
 ```
+The YDK requires Go version 1.9 or higher. If this is not the case, follow below installation steps. Make sure that environment variables GOROOT and GOPATH are properly set.
+```
+$ export CGO_ENABLED=0
+$ export GOROOT_BOOTSTRAP=$GOROOT
+$ gvm install go1.9.2
+```
 
-### Installing
+### Installing YDK
 
 You can install the latest `ydk` package using:
 ```

sdk/go/core/README.md

@@ -1,6 +1,8 @@
-### YDK GO
+### YDK GO Core and Bundle Installation
 
-To build, first install [C++ core](https://github.com/CiscoDevNet/ydk-gen#second-step-generate--install-the-core). Then execute the below steps to install the ydk package.
+The YDK requires Go version 1.9 or higher. Make sure that corresponding software is installed and environment variables GOROOT and GOPATH are properly set before the YDK installation. Follow System Requirements [here](https://github.com/CiscoDevNet/ydk-gen/tree/master/sdk/go#system-requirements).
+
+First, install [C++ core](https://github.com/CiscoDevNet/ydk-gen#second-step-generate--install-the-core). Then execute the below steps to install the ydk go core and bundle packages.
 
 ```
 $ go get gopkg.in/stretchr/testify.v1