Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Its not like everything must have a dot. #1022

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Its not like everything must have a dot. #1022

merged 1 commit into from
Oct 29, 2020

Conversation

DaEgi01
Copy link
Contributor

@DaEgi01 DaEgi01 commented Oct 29, 2020

We are not typo nazis are we? :D

@DaEgi01
Copy link
Contributor Author

DaEgi01 commented Oct 29, 2020 •
edited
Loading

for context
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1629.md

kvakvs
kvakvs approved these changes Oct 29, 2020
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was ok with this rule, but will not be sad to see it go 👍

@DaEgi01 DaEgi01 merged commit 8003dde into master Oct 29, 2020
@DaEgi01 DaEgi01 deleted the DotKiller branch October 29, 2020 23:44
@originalfoo originalfoo added the meta Build environment, github environment, etc. label Jan 18, 2022
@originalfoo originalfoo added this to the 11.6.0 milestone Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees
No one assigned
Labels
meta Build environment, github environment, etc.
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@DaEgi01 @kvakvs @krzychu124 @originalfoo