SpeedLimits stage 1: U interface and texture loading changed

[kvakvs]

• Texture and texture-atlas loading changed: now you can define desired texture size
• RoadDefaults textures commented out will be added and loaded in the following update

[krzychu124]

Looks good to me 👍

[kianzarrin]

I can understand that there is the issue of confusing this with unity object but if you simply use object. that would work too.
Just a side note. no need to fix.

[kianzarrin]

Window has opacity but components have transparency ... a bit inconsistent. I understand fixing this might need a lot of code changes and might be out of the scope of this review. so no pressure.

[kianzarrin]

I have selected the parking tool. but no parking overlay

EDIT: once I rotate the screen the parking overlay reappears

This is sometimes reproducible and sometimes not. So for example:

• switch to speed tool -> switch to parking tool -> parking sprites are visible
• switch to Vehicle restriction tool -> exit Vehicle restriction tool -> switch to parking tool -> parking sprites not visible until I rotate the screen.

[kianzarrin]

see #1044 (comment)

[krzychu124]

I have selected the parking tool. but no parking overlay

EDIT: once I rotate the screen the parking overlay reappears

This is sometimes reproducible and sometimes not. So for example:

• switch to speed tool -> switch to parking tool -> parking sprites are visible
• switch to Vehicle restriction tool -> exit Vehicle restriction tool -> switch to parking tool -> parking sprites not visible until I rotate the screen.

Pretty old bug, introduced with camera position caching mechanism.

[kvakvs]

@kianzarrin For opacity/transparency, the work you mentioned is already done. I store the opacity/transparency in the same float value, in a struct. Its probably the UI inconsistency here?
@krzychu124 The bug is not introduced in this branch? Happy to fix it, but not all problems at once :)

[kianzarrin]

In that case looks good to me

[krzychu124]

@kvakvs I think it was introduced when you've added camera transform cache thingy to speed up rendering of overlays long time ago. If you don't move camera and switch tool with overlays they won't show up until you move it a little bit

[kvakvs]

I am slowly refactoring overlays into separate modules one per tool.
Can have this as a TODO item in the final Pull request for Speed Limits if its urgent, or as some high prio bug to do after it

[krzychu124]

Yeah I'm waiting for speed limits refactor to begin some work on performance improvements. I plan to improve TM:PE to be able to run it with Unity profiler. I'm not sure yet what changes are necessary to make it work and not crash at start

[EDIT]
You can merge it if that's all for this PR