Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CitiesHarmony API upgrade #1059

Merged
merged 1 commit into from
Feb 20, 2021
Merged

CitiesHarmony API upgrade #1059

merged 1 commit into from
Feb 20, 2021

Conversation

krzychu124
Copy link
Member

  • CitiesHarmony API upgrade
  • removed unused packages:
    • SkyTools.Common
    • SkyTools.Patching - incompatible with Harmony 2.x (dependency Lib.Harmony=1.2.0.1)

@krzychu124 krzychu124 added technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability labels Feb 17, 2021
@krzychu124 krzychu124 added this to the 11.6.0 milestone Feb 17, 2021
@krzychu124 krzychu124 self-assigned this Feb 17, 2021
chameleon-tbn
chameleon-tbn approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@krzychu124 krzychu124 merged commit 3ba1f2f into master Feb 20, 2021
@krzychu124 krzychu124 deleted the improvement/cities-harmony-api-upgrade branch February 20, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaEgi01 DaEgi01 DaEgi01 approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

@kianzarrin kianzarrin Awaiting requested review from kianzarrin

Assignees

@krzychu124 krzychu124

Labels
code cleanup Refactor code, remove old code, improve maintainability Harmony technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@krzychu124 @DaEgi01 @chameleon-tbn @originalfoo