Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version bump, compatibility fix for new BloodyPenguin's mod #1103

Merged
merged 1 commit into from
May 9, 2021
Merged

Version bump, compatibility fix for new BloodyPenguin's mod #1103

merged 1 commit into from
May 9, 2021

Conversation

krzychu124
Copy link
Member

TM:PE Stable v.11.5.2

Little compatibility hotfix for upcoming @bloodypenguin's mod - support for new forms of transporting cargo (water and air)

Note:
Current master branch does not require any changes because it will be fully compatible (we don't patch the same methods)

@krzychu124 krzychu124 added the STABLE TM:PE STABLE branch label May 5, 2021
@krzychu124 krzychu124 self-assigned this May 5, 2021
@krzychu124 krzychu124 changed the title Version bump, compatibility fix for new BloodyPenguin mod Version bump, compatibility fix for new BloodyPenguin's mod May 5, 2021
kvakvs
kvakvs approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@krzychu124
Copy link
Member Author

Mod Teaser, if you are curious what is it 🙃

barges teaser

@kianzarrin
Copy link
Collaborator

what does the mod do?

kianzarrin
kianzarrin approved these changes May 9, 2021
View reviewed changes
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to add all these vehicle types to a relevant constant. but we are getting rid of CustomAI anyway so it does not matter for now.

I am not sure what the mod does and why this change is required but at least it's consistent.

@krzychu124
Copy link
Member Author

This mod will add cargo ferries(barges) which will use canals to transport cargos.
Vanilla does not have ferryAI for transport cargo and there is no ferry cargo port AI, so without assets with new AIs and barges (also with new AI) it won't make any difference.

@krzychu124 krzychu124 merged commit 835eddc into release-stable-11.5 May 9, 2021
@krzychu124 krzychu124 deleted the hotfix/release-stable-11.5.2 branch May 9, 2021 12:07
@krzychu124 krzychu124 added this to the 11.6.0 milestone May 16, 2021
@originalfoo originalfoo modified the milestones: 11.6.0, 11.5.2-reverted Jan 19, 2022
@originalfoo originalfoo added COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@kianzarrin kianzarrin kianzarrin approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@krzychu124 krzychu124

Labels
COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor STABLE TM:PE STABLE branch
Projects
None yet
Milestone
11.5.2-reverted
Development

Successfully merging this pull request may close these issues.
4 participants
@krzychu124 @kianzarrin @kvakvs @originalfoo