Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag extension #1118

Merged
merged 2 commits into from
Jun 8, 2021
Merged

flag extension #1118

merged 2 commits into from
Jun 8, 2021

Conversation

kianzarrin
Copy link
Collaborator

previously IsFlagSet was using CO's extension which allocates heap memory in each frame.
I introduced our own IsFlagSet for every Enum [that we use] to avoid using heap memory.

@kianzarrin kianzarrin added the performance Make it faster! label Jun 2, 2021
@kianzarrin kianzarrin self-assigned this Jun 2, 2021
@DaEgi01 DaEgi01 self-requested a review June 2, 2021 18:10
DaEgi01
DaEgi01 approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@DaEgi01 DaEgi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!
why internal though?

@krzychu124
Copy link
Member

@kianzarrin, you can merge it if you think is complete 😉

@kianzarrin kianzarrin merged commit 1d423ac into master Jun 8, 2021
@kianzarrin
Copy link
Collaborator Author

@DaEgi01

why internal though?

why not internal?

@DaEgi01
Copy link
Contributor

DaEgi01 commented Jun 8, 2021

@DaEgi01

why internal though?

why not internal?

Because when I look at it I see nothing about this function that is specific to TMPE.
Its more of a CSUtil.Commons thing that should be public for other assemblies to use freely.
But I don't mind leaving it as is, just thought that you have particular reasons maybe.

@originalfoo originalfoo added this to the 11.6.0 milestone Dec 23, 2021
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.0.2 Jan 18, 2022
@originalfoo originalfoo deleted the IsFlagSet-hmem branch January 18, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaEgi01 DaEgi01 DaEgi01 approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@kianzarrin kianzarrin

Labels
performance Make it faster!
Projects
None yet
Milestone
11.6.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@kianzarrin @krzychu124 @DaEgi01 @originalfoo