Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved half-segment detection #1141

Merged
merged 2 commits into from
Aug 6, 2021
Merged

Improved half-segment detection #1141

merged 2 commits into from
Aug 6, 2021

Conversation

krzychu124
Copy link
Member

@krzychu124 krzychu124 commented Jul 30, 2021 •
edited
Loading

Closes #1138

@krzychu124 krzychu124 added BUG Defect detected Usability Make mod easier to use UI User interface updates regression old bug comes back or a new bug introduced in code that used to work. labels Jul 30, 2021
@krzychu124 krzychu124 added this to the 11.6.0 milestone Jul 30, 2021
@krzychu124 krzychu124 self-assigned this Jul 30, 2021
chameleon-tbn
chameleon-tbn approved these changes Jul 31, 2021
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, no issues for me ingame with that fix

@krzychu124 krzychu124 requested review from kianzarrin and removed request for kianzarrin August 3, 2021 19:30
kianzarrin
kianzarrin approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@krzychu124 krzychu124 merged commit 3d8c533 into master Aug 6, 2021
@krzychu124 krzychu124 deleted the bugfix/1138-half-segment-detection branch August 6, 2021 00:17
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.1 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianzarrin kianzarrin kianzarrin approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected regression old bug comes back or a new bug introduced in code that used to work. UI User interface updates Usability Make mod easier to use
Projects
None yet
Milestone
11.6.1
Development

Successfully merging this pull request may close these issues.

regression: its hard to select half segment in lane arrow tool
4 participants
@krzychu124 @kianzarrin @chameleon-tbn @originalfoo