Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hardcoded CitizenUnit buffer limits with buffer size detection #1192

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Replace hardcoded CitizenUnit buffer limits with buffer size detection #1192

merged 2 commits into from
Nov 11, 2021

Conversation

algernon-A
Copy link
Contributor

For compatibility with mods that change the size of the CitizenUnit buffer.

Tested for stability and performance both with and without More CitizenUnits mod (development versions); no issues detected.

krzychu124
krzychu124 approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@DaEgi01 DaEgi01 self-requested a review November 11, 2021 17:35
@DaEgi01 DaEgi01 merged commit f0709aa into CitiesSkylinesMods:master Nov 11, 2021
@originalfoo originalfoo added this to the 11.6.0 milestone Dec 23, 2021
@originalfoo originalfoo added the EXTERNAL Mod conflict or other external factor label Dec 23, 2021
@krzychu124 krzychu124 mentioned this pull request Jan 8, 2022
Merged
@originalfoo originalfoo added the COMPATIBILITY Mod (in)compatibility / checker label Jan 18, 2022
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaEgi01 DaEgi01 DaEgi01 approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

Assignees
No one assigned
Labels
COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor
Projects
None yet
Milestone
11.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@algernon-A @DaEgi01 @krzychu124 @originalfoo