-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetNode/Segment -> ToNode/Segment #1202
Conversation
GetNode(nodeID) with ToNode() GetSeg(segmentID) with ToSegment() renamed: GetNode(segment, startNode) to GetNodeID(segment, startNode)
@@ -71,7 +71,7 @@ public class LaneConnectionManager | |||
private bool IsHeadingTowardsStartNode(uint sourceLaneId) { | |||
NetLane[] laneBuffer = NetManager.instance.m_lanes.m_buffer; | |||
ushort segmentId = laneBuffer[sourceLaneId].m_segment; | |||
NetSegment segment = GetSeg(segmentId); | |||
NetSegment segment = segmentId.ToSegment(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref ref :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should take a look at macsurgeys code! he refuses to use ref as a matter of principle!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha lol, it does not mean we should not do better though :) what was the sizeof(NetSegment) again? can't check atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just kidding!
@DaEgi01 In any case if you didn't notice I already fixed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright
GetNode(nodeID) with ToNode()
GetSeg(segmentID) with ToSegment()
renamed:
GetNode(segment, startNode) to GetNodeID(segment, startNode) because the return value is ushort not ref NetNode