Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static texture classes are now proper CustomManagers #1265

Merged
merged 5 commits into from
Jan 5, 2022

Conversation

kvakvs
Copy link
Collaborator

@kvakvs kvakvs commented Jan 2, 2022

  • Texture classes are not static anymore
  • On level loaded, all textures are loaded too
  • On level unloaded, textures are freed

In debug build this creates visible delay. Should we show a progress indicator or some short-time notification to let the player know that we're loading?

@originalfoo originalfoo added Overlays Overlays, data vis, etc. technical Tasks that need to be performed in order to improve quality and maintainability UI User interface updates labels Jan 2, 2022
@originalfoo originalfoo added this to the 11.6.0 milestone Jan 2, 2022
Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice any issue with regards to memory leaking, or hot-reloading. Everything works flawlessly.

@chameleon-tbn chameleon-tbn self-requested a review January 5, 2022 11:34
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seems to work flawless with this build, therefor i give it a go.

@kvakvs kvakvs merged commit 23ee4b2 into CitiesSkylinesMods:master Jan 5, 2022
@krzychu124 krzychu124 mentioned this pull request Jan 8, 2022
@originalfoo originalfoo modified the milestones: 11.6.0, 11.6.2 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Overlays Overlays, data vis, etc. technical Tasks that need to be performed in order to improve quality and maintainability UI User interface updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants