Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place Intersection improvements, bugfixing #1308

Merged
merged 4 commits into from
Jan 25, 2022
Merged

Place Intersection improvements, bugfixing #1308

merged 4 commits into from
Jan 25, 2022

Conversation

krzychu124
Copy link
Member

Closes #1307

  • changed patch instruction injection from inserting before list clear call to inserting after end of the loop (reduces chance of incompatibilities in case of transpiling the same method by the other mods)
  • delaying traffic rules application to the end of simulation step (not perfect solution)
  • removed calls forcing node/segment recalculation - may trigger additional calls to (BuildingDecoration.LoadPaths() breaking traffic rules application and also other mods relying on contents of tempNodeBuffer/tempSegmentBuffer collections

Build zip

@krzychu124
Append patch after known vanilla instruction instead of inserting bef…
2cc1ebc 
…ore it (improves compatibility)
@krzychu124
Delay transfering records to the end of simulation step, remove force…
1488948 
… call to node/segment recalculation - may break transfering and other mods
@krzychu124 krzychu124 added BUG Defect detected EXTERNAL Mod conflict or other external factor Asset Editor Issue related to TM:PE support in content editors labels Jan 23, 2022
@krzychu124 krzychu124 added this to the 11.6.4 milestone Jan 23, 2022
@krzychu124 krzychu124 self-assigned this Jan 23, 2022
originalfoo added a commit that referenced this pull request Jan 23, 2022
@originalfoo
Add #1308 to changes list
2e64363
@originalfoo originalfoo mentioned this pull request Jan 23, 2022
Merged
originalfoo
originalfoo approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built from source as RELEASE, tested in game, didn't encounter any problems.

chameleon-tbn
chameleon-tbn approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ingame, all good.

@krzychu124 krzychu124 merged commit 0f286f2 into master Jan 25, 2022
@krzychu124 krzychu124 deleted the 1307-place-intersection-restore-bugfix branch January 25, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianzarrin kianzarrin kianzarrin left review comments

@originalfoo originalfoo originalfoo approved these changes

@chameleon-tbn chameleon-tbn chameleon-tbn approved these changes

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@krzychu124 krzychu124

Labels
Asset Editor Issue related to TM:PE support in content editors BUG Defect detected EXTERNAL Mod conflict or other external factor
Projects
None yet
Milestone
11.6.4
Development

Successfully merging this pull request may close these issues.

Mod conflict IMT, NCR - Place intersection data restore failing
4 participants
@krzychu124 @originalfoo @kianzarrin @chameleon-tbn