Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear all node rules #1668

Merged
merged 8 commits into from
Oct 28, 2022
Merged

clear all node rules #1668

merged 8 commits into from
Oct 28, 2022

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Oct 7, 2022

fixes: #692
when no subtool is selected alt-click on a node and then press delete to clear all node rules (except TTL).

TMPE.zip

@kianzarrin kianzarrin self-assigned this Oct 8, 2022
@kianzarrin kianzarrin marked this pull request as ready for review October 8, 2022 06:29
@kvakvs
Copy link
Collaborator

kvakvs commented Oct 16, 2022

Built and tested from branch and it works
Languages not updated, shows translation keys (without ¶)
bild

Problem: Holding CTRL shows existing speed limits, but then Speed limits overlay checks if CTRL is pressed, and shows speeds per lane. That's probably too much detail, need to make Speed limits overlay to ignore pressed Ctrl if in this mode?

Still confusing as i tried to apply this to lane connectors and it naturally did not change lane connectors.
But is it possible to include lane connectors in this delete function? Makes any sense?

@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Oct 16, 2022

@kvakvs

Built and tested from branch and it works

did you use alt-click to select node and delete rules? the tooltips on your screen suggests you did.

Still confusing as i tried to apply this to lane connectors and it naturally did not change lane connectors.

Apply what? clearing node rules does clear lane connections for me. are you talking about clearing rules when selecting segment?

Problem: Holding CTRL shows existing speed limits, but then Speed limits overlay checks if CTRL is pressed, and shows speeds per lane. That's probably too much detail, need to make Speed limits overlay to ignore pressed Ctrl if in this mode?

Interesting observation. created #1680

@kvakvs
Copy link
Collaborator

kvakvs commented Oct 16, 2022

Still confusing as i tried to apply this to lane connectors and it naturally did not change lane connectors.

Apply what? clearing node rules does clear lane connections for me. are you talking about clearing rules when selecting segment?

I was unable to clear lane connectors using this feature.

Copy link
Contributor

@chameleon-tbn chameleon-tbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kianzarrin kianzarrin merged commit 2d897c7 into master Oct 28, 2022
@kianzarrin kianzarrin deleted the clear-node branch October 28, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eraser button on main toolbar
3 participants