debug switches UI #1696
debug switches UI #1696
Conversation
|
|
| /// <summary> | ||
| /// Indexes into Debug.Switches | ||
| /// </summary> | ||
| [Flags] |
There was a problem hiding this comment.
Why bit flags and not multiple boolean? Is there any need to pack all bits into 1 integer?
There was a problem hiding this comment.
it makes more sense this way. why to write extra code? why to have code duplication?
and we are not serializing anything anymore so there is no need for array.
There was a problem hiding this comment.
Reason is that checking a processor-register wide boolean (64 bit) is faster than reading and masking a bit, with same result. Not important if all code for this is deleted in a Release build.
There was a problem hiding this comment.
Yes that code won't run in Release build, at least it shouldn't
There was a problem hiding this comment.
I am just trying to keep it simple.
kianzarrin
force-pushed
the
DebugSwitches
branch
from
5ae5733
to
4d107d0
Compare
|
@kianzarrin build is failing because: |
Debug switches are now handled by in game UI interface from the options panel and from the debug panel (code copied despawn panel).
They are not longer saved to XML since they can now be set using the UI interface.
changed debug switches to flags.
TrafficManager.zip