Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete Bank vans detection #1713

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Incomplete Bank vans detection #1713

merged 1 commit into from
Dec 23, 2022

Conversation

krzychu124
Copy link
Member

Add missing BankVanAI to correctly determine vehicle type. Affects vehicle restrictions and junction restrictions features - was detected as not eligible to use turn on red feature or not following Service Vehicles restriction

@krzychu124 krzychu124 added BUG Defect detected STABLE TM:PE STABLE branch JUNCTION RESTRICTIONS Feature: Junction restrictions TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc VEHICLE RESTRICTIONS Feature: Vehicle restrictions TEST TEST version of the mod / workshop page labels Dec 22, 2022
@krzychu124 krzychu124 self-assigned this Dec 22, 2022
@krzychu124 krzychu124 added this to the 11.7.3.1 milestone Dec 22, 2022
kianzarrin
kianzarrin approved these changes Dec 22, 2022
View reviewed changes
Copy link
Collaborator

@kianzarrin kianzarrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the mysterious HarmonyPriority attribute, everything else looks fine.

@kianzarrin
Copy link
Collaborator

where is the test for this?
how can I reproduce previous failure.
how do I test this is working now?

@krzychu124
Copy link
Member Author

where is the test for this? how can I reproduce previous failure. how do I test this is working now?

Test is relatively simple, as described in the description.
Not sure if I need to repeat myself, but in short:

  • bank vans cannot use turn-on-red feature at node with timed traffic lights
  • they don't respect service vehicle restriction on roads because the AI is not recognized as service vehicle (but the main part for searching for path as a service vehicle was already working correctly, so the patch is not so important as the fallback code for detection by vehicle category in CreatePath already works correctly)

@kianzarrin
Copy link
Collaborator

test passed

@krzychu124 krzychu124 merged commit ff17b2d into master Dec 23, 2022
@krzychu124 krzychu124 deleted the bugfix/bank-van-ai-vehicle-type-detection branch December 23, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvakvs kvakvs kvakvs approved these changes

@kianzarrin kianzarrin kianzarrin approved these changes

@chameleon-tbn chameleon-tbn Awaiting requested review from chameleon-tbn

Assignees

@krzychu124 krzychu124

Labels
BUG Defect detected JUNCTION RESTRICTIONS Feature: Junction restrictions STABLE TM:PE STABLE branch TEST TEST version of the mod / workshop page TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc VEHICLE RESTRICTIONS Feature: Vehicle restrictions
Projects
None yet
Milestone
11.7.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@krzychu124 @kianzarrin @kvakvs