Prevent the user from setting invalid Lane Arrows, update if lane connections exist #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- calculate and refresh allowed lane arrows - reset custom lane arrows when after segment or node update set of available lane arrows is significantly different (segment supports more or less arrow directions than before) - block invalid Lane Arrows in Tool UI - update lane arrows if lane has lane connection(s)
- fixed lane flag recalculation after validation phase
krzychu124
added
BUG
krzychu124
requested review from
kvakvs,
DaEgi01,
kianzarrin and
chameleon-tbn
chameleon-tbn
approved these changes
Feb 20, 2023
Closed
kvakvs
approved these changes
Mar 9, 2023
| @@ -215,6 +217,9 @@ private enum Trigger { | |||
| buttonLeft.ToggleFlag = API.Traffic.Enums.LaneArrows.Left; | |||
| buttonLeft.UpdateButtonSkinAndTooltip(); | |||
| buttonLeft.ParentTool = this; // to access error reporting function on click | |||
| bool leftAllowed = (availableArrows & LaneArrows.Left) != 0; | |||
| buttonLeft.isEnabled = leftAllowed; | |||
| buttonLeft.tooltip = !leftAllowed ? T("LaneArrow: Direction not available") : string.Empty; | |||
There was a problem hiding this comment.
Translations, have they been updated?
There was a problem hiding this comment.
true, need to be updated/string needs to be added 😉
There was a problem hiding this comment.
I'll create new PR with translations
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #368
Enhancements in this PR:
Lane Arrowson loadSegmentEndLane Arrowsin the Tool UI, shows a tooltip for disabled arrowsLane Arrowsif the lane has anyLane Connection(s), to match direction of the lane connection_RoadBaseAI/SegmentSimulationStepPatchsince it does not provide any value other than wasting CPU timeProvided enhancements will solve a lot of mysterious issues reported by users in the past few years. Sometimes, for some reason (most likely segment update or bug in other feature) custom lane arrows became invalid, effectively causing huge pathfinding issues (including infamous "no cims coming from outside" when the users started a new city), since invalid arrows either don't create any lane transitions or only those of type "relaxed" which come with significant penalty for pathfinding when selected for regular vehicles.
Build ZIP