-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dedicated turning lanes phase2 #755
dedicated turning lanes phase2 #755
Conversation
…ions to the code has been made.
support for bus lanes
Ignore those two comments I added (now deleted) - had built the wrong PR, doh!! |
There are arcs of angles somewhere in our code, which correspond to arrow directions. I suggest someone find them, check whether they match what the game is using, and maybe move out somewhere to lane arrow manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code's looking good.
Looks like this branch is based on 11.1.0 tag - can you rebase to master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above
@aubergine10 @kvakvs I merged in the latest master version. |
Note: Left Hand Traffic issue 2 - wrong arrowsVanilla: ![image](https://user-images.githubusercontent.com/1386719/78327082-ead8ff80-7573-11ea-9f96-f9f9859b9f18.png) |
I will check it out but most likely needs a issue with saved game and fixed camera attached to it (there is mod for that). |
I fixed the bug in my code. Now lane arrows should be right. |
@aubergine10 I didn't manage to reproduce this. Can you please create city with minimum test case and attach it to issue (please create new issue) |
Testing again now.... If I manage to recreate issue 3 I'll try and create a save with vanilla + TMPE and nothing else and attach to new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in-game: It's working great now! And no recurrence of issue 3 either.
LGTM from end-user perspective! 👍
This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just little issues, but works great
@kvakvs can this be merged now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm ok with that
fixes #567
dedicated turning lanes now has a state-machine of 2-states:
Notes:
Test:
I have tested it on 1 lanes 2 lanes and 3 lanes and 12 lane roads with and without bus lanes with and without left hand drive.