Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stay-in-lane for MOM tracks #919

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Fix stay-in-lane for MOM tracks #919

merged 1 commit into from
Jun 2, 2020

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Jun 2, 2020

image
Bug: stay in lane was not working for MOM tracks because I was using PriorityRoad.CountLanes*() which used lane/vehicle types supported by lane arrow manager.
Fix: see diff.
I copy pasted the PriorityRoad.CountLanes*() into Lane Connector Subtool and change lanes/vehicle types to the ones supported by lane connection manager.

Copy link
Member

@krzychu124 krzychu124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@kvakvs kvakvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Member

@originalfoo originalfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@originalfoo originalfoo added the LANE ROUTING Feature: Lane arrows / connectors label Jun 2, 2020
@originalfoo originalfoo added this to the 11.6.0 milestone Jun 2, 2020
@originalfoo originalfoo changed the title fixed stay-in-lane for MOM tracks. Fix stay-in-lane for MOM tracks Jun 2, 2020
@kianzarrin kianzarrin merged commit 036f144 into master Jun 2, 2020
@kianzarrin kianzarrin deleted the stay-in-lane-tracks branch June 2, 2020 18:12
@originalfoo originalfoo added COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMPATIBILITY Mod (in)compatibility / checker EXTERNAL Mod conflict or other external factor LANE ROUTING Feature: Lane arrows / connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants