Make it easier to debug harmony problems #933
Conversation
| Log.Info(e.StackTrace); | ||
| Log.Error("Could not apply Harmony patches because the following exception occured:\n " + | ||
| e + | ||
| "\n -- End of inner exception stack trace -- "); |
There was a problem hiding this comment.
The stack trace from error would be appended to the end of the log
There was a problem hiding this comment.
Yeah, exception.ToString() is much better than the alternatives, since we have all the infos right there. No need to do basically the same with e.Message.ToString() + e.StackTrace.ToString().
There was a problem hiding this comment.
One problem: have you tried causing an error?
Re-thrown exception from CitiesHarmony doesn't put any useful information where was the problem. It's general info: "...an error occurred while patching, blah, blah, blah..."
I noticed it when I've been experimenting with migration of TrainAI redirection to harmony and I renamed parameter names. Back then I've had to run debugger to get any info what was wrong
originalfoo
added
Harmony
technical
| @@ -94,6 +94,12 @@ public class TrafficManagerMod : IUserMod { | |||
| InGameHotReload = InGame(); | |||
|
|
|||
| HarmonyHelper.EnsureHarmonyInstalled(); | |||
|
|
|||
| #if DEBUG | |||
| const bool installHarmonyASAP = false; // set true for fast testing | |||
There was a problem hiding this comment.
I don't like the solution but I guess its better than nothing for the time beeing.
So i m fine with that.
| #if DEBUG | ||
| const bool installHarmonyASAP = false; // set true for fast testing | ||
| if (installHarmonyASAP) | ||
| HarmonyHelper.DoOnHarmonyReady(delegate () { Patcher.Create().Install(); }); |
There was a problem hiding this comment.
Can you use lambdas instead?
this delegate () syntax is out of vogue since c# 3.0 and only left in for backwards compat.
This reverts commit 2374027.
Problem: If an exception occurs in a harmony patch in TargetMethod, The exception is not printed. Also, I have to wait until the game is loaded to test if my harmony patch has an exception or not.
Solution: I added a conditional code to test harmony patches when mod is enabled. Also, I changed the code to print all layers of the exception log.