Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial migration of VehicleAI.StartPathFind into harmony. #943

Merged
merged 39 commits into from
Jun 15, 2020
Merged

partial migration of VehicleAI.StartPathFind into harmony. #943

merged 39 commits into from
Jun 15, 2020

Conversation

kianzarrin
Copy link
Collaborator

@kianzarrin kianzarrin commented Jun 12, 2020 •
edited
Loading

partially f i x es #895

I have written harmony patches for all VehicleAI.StartPathFind() except for TransportLineAI (which is complicated)

How to review code:

  • decompile CS code and TrafficManager.DLL using the same decompiler.
  • take a diff between StartPathFind and TMPE CustomStartPathFind
  • make sure all differences are addressed in my harmony patches.
  • start the review by looking at PathManager.CreatePathPatch()
  • then look at each individual path for each subclass of VehicleAI
  • see comments in migrate custom start path find to harmony. #895.

Patch summary:

  • some redirections of CustomStartPathFind() call to OnStartPathFind(). This is reflected in my patches
  • skipQueue=true (if spawned)
  • PostVanAI, CustomTruckAI has a transpiler to be compatible with 81 tiles.

TODOs:
Please tell me what do you think about the //TODO [issue] in my code? should I simply delete them or create new issues for them? I created new issues.

@kianzarrin
Harmony2 - manual patch
44bf23f
@kianzarrin
Harmony2 working
51294ca
@kianzarrin
Cities Harmony is woring.
2eabc1b
@kianzarrin
new LifeCycle directory.
206f306 
removed redundant/commented out code.
@kianzarrin
85f9d95
@kianzarrin
revived vehcileAI commented out code with TODO issue number.
def7b65
@kianzarrin
fixed post build script.
008c8d6
@kianzarrin
Undid move to LifeCycle to reduce the size of PR
4bdc0ed
@kianzarrin
f8d2cc0
@kianzarrin
331cccf
@kianzarrin
Merge remote-tracking branch 'origin/master' into harmony2-2
32ca486
@kianzarrin
merged with trunk
187da37
@kianzarrin
added harmony_Id to unpatchall().
8df57a0 
removed redundant code.
@kianzarrin
8b02f94
@kianzarrin
Moved BusAI and AmbulanceAI to harmony.
26036af
@kianzarrin
merged with master
0e7ab52
@kianzarrin
intermidate
d550a64
@kianzarrin
Completed several AI's and fixed bugs from others.
817ddee
@kianzarrin
fixed TargetMethod
84f66a8
@kianzarrin
Merge remote-tracking branch 'origin/master' into 895-VehcileAI-to-ha…
337e137 
…rmony
@kianzarrin
merge with master.
4a43936
@kianzarrin
update submodules
5b72de9
@kianzarrin
Merge branch 'major-feature-harmony2-migration' of https://github.com…
109f585 
…/CitiesSkylinesMods/TMPE into major-feature-harmony2-migration
@kianzarrin
fixed CargoTruckAI transpiler.
7ad3a96
@kianzarrin kianzarrin requested review from kvakvs, DaEgi01, krzychu124 and originalfoo and removed request for kvakvs June 12, 2020 08:28
@kianzarrin kianzarrin requested review from krzychu124, kvakvs and originalfoo and removed request for kvakvs and originalfoo June 13, 2020 05:46
@originalfoo originalfoo added the PATHFINDER Pathfinding tweaks or issues label Jun 13, 2020
@kianzarrin
Copy link
Collaborator Author

kianzarrin commented Jun 13, 2020 •
edited
Loading

@aubergine10 Thanks for the review. I addressed your comments. I am glad that there was only a couple of minor comment problems.

About the TODOs in my code ... should I create new issues, or should I just delete them?

@originalfoo originalfoo added this to the 11.6.0 milestone Jun 13, 2020
@originalfoo
Copy link
Member

Should this PR be marked as fixing #462

@kianzarrin
Copy link
Collaborator Author

@krzychu124 You requested changes ... I fixed them :) Can you please unblock the review?

@kianzarrin
Copy link
Collaborator Author

partial migration of VehicleAI.StartPathFind into harmony (#895)
Migration Vehicle spawn/despawn patch to harmony. (#864)

@kianzarrin kianzarrin merged commit 9887d79 into major-feature-harmony2-migration Jun 15, 2020
@originalfoo
Copy link
Member

originalfoo commented Jun 15, 2020 •
edited
Loading

delete branch? vv

@kianzarrin
Copy link
Collaborator Author

I don't know. It might be useful to keep this if anything happened to harmony feature branch.

@krzychu124 krzychu124 mentioned this pull request Feb 20, 2021
Merged
4 tasks
@originalfoo originalfoo deleted the 895-VehcileAI-to-harmony branch January 19, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@originalfoo originalfoo originalfoo approved these changes

@krzychu124 krzychu124 krzychu124 approved these changes

@DaEgi01 DaEgi01 Awaiting requested review from DaEgi01

@kvakvs kvakvs Awaiting requested review from kvakvs

Assignees

@kianzarrin kianzarrin

Labels
code cleanup Refactor code, remove old code, improve maintainability enhancement Improve existing feature Harmony PATHFINDER Pathfinding tweaks or issues technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Milestone
11.6.0
Development

Successfully merging this pull request may close these issues.

migrate custom start path find to harmony.
3 participants
@kianzarrin @originalfoo @krzychu124