-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post build script to create mdb file for file and line numbers #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianzarrin
changed the title
post build script creates mdb file for file and line numbers
post build script to create mdb file for file and line numbers
Jul 7, 2020
kianzarrin
requested review from
originalfoo,
DaEgi01,
kvakvs,
dymanoid and
krzychu124
July 8, 2020 05:31
dymanoid
suggested changes
Jul 8, 2020
Co-authored-by: dymanoid <9433345+dymanoid@users.noreply.github.com>
Co-authored-by: dymanoid <9433345+dymanoid@users.noreply.github.com>
Co-authored-by: dymanoid <9433345+dymanoid@users.noreply.github.com>
Thanks dynamoid for the change suggestion. Does the code look good? |
originalfoo
approved these changes
Jul 10, 2020
originalfoo
added
docs
Documentation
technical
Tasks that need to be performed in order to improve quality and maintainability
labels
Jul 10, 2020
krzychu124
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://github.com/kianzarrin/PedestrianBridge/issues/7 I have explained how to print out file and line numbers of stack trace to output log.
in this review, I generate the MDB file in the post-build script.
Requirement:
PS: I think we should upload mdb file to the workshop so pro users would be able to generate file and line numbers in their logs.