Skip to content

Commit

Permalink
Fix migration script not being able to run if it fails midway (mastod…
Browse files Browse the repository at this point in the history
…on#16312)

* Fix migration script not being able to run if it fails midway

* Fix old migration script

* Fix old migration script

* Refactor CorruptionError
  • Loading branch information
ClearlyClaire committed Jan 28, 2022
1 parent 31d9aa8 commit 1b32c00
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@ def up
Tag.where(id: redundant_tag_ids).in_batches.delete_all
end

safety_assured { execute 'CREATE UNIQUE INDEX CONCURRENTLY index_tags_on_name_lower ON tags (lower(name))' }
begin
safety_assured { execute 'CREATE UNIQUE INDEX CONCURRENTLY index_tags_on_name_lower ON tags (lower(name))' }
rescue ActiveRecord::StatementInvalid
remove_index :tags, name: 'index_tags_on_name_lower'
raise
end

remove_index :tags, name: 'index_tags_on_name'
remove_index :tags, name: 'hashtag_search_index'
end
Expand Down
17 changes: 6 additions & 11 deletions db/migrate/20200620164023_add_fixed_lowercase_index_to_accounts.rb
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
class AddFixedLowercaseIndexToAccounts < ActiveRecord::Migration[5.2]
disable_ddl_transaction!
require Rails.root.join('lib', 'mastodon', 'migration_helpers')

class CorruptionError < StandardError
def cause
nil
end
class AddFixedLowercaseIndexToAccounts < ActiveRecord::Migration[5.2]
include Mastodon::MigrationHelpers

def backtrace
[]
end
end
disable_ddl_transaction!

def up
if index_name_exists?(:accounts, 'old_index_accounts_on_username_and_domain_lower') && index_name_exists?(:accounts, 'index_accounts_on_username_and_domain_lower')
Expand All @@ -21,7 +15,8 @@ def up
begin
add_index :accounts, "lower (username), COALESCE(lower(domain), '')", name: 'index_accounts_on_username_and_domain_lower', unique: true, algorithm: :concurrently
rescue ActiveRecord::RecordNotUnique
raise CorruptionError, 'Migration failed because of index corruption, see https://docs.joinmastodon.org/admin/troubleshooting/index-corruption/#fixing'
remove_index :accounts, name: 'index_accounts_on_username_and_domain_lower'
raise CorruptionError
end

remove_index :accounts, name: 'old_index_accounts_on_username_and_domain_lower' if index_name_exists?(:accounts, 'old_index_accounts_on_username_and_domain_lower')
Expand Down
14 changes: 14 additions & 0 deletions lib/mastodon/migration_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,20 @@

module Mastodon
module MigrationHelpers
class CorruptionError < StandardError
def initialize(message = nil)
super(message.presence || 'Migration failed because of index corruption, see https://docs.joinmastodon.org/admin/troubleshooting/index-corruption/#fixing')
end

def cause
nil
end

def backtrace
[]
end
end

# Stub for Database.postgresql? from GitLab
def self.postgresql?
ActiveRecord::Base.configurations[Rails.env]['adapter'].casecmp('postgresql').zero?
Expand Down

0 comments on commit 1b32c00

Please sign in to comment.