Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mktempdir for regridding #972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use mktempdir for regridding #972

wants to merge 1 commit into from
+221 −250

Conversation

juliasloan25
Copy link
Member

Purpose

closes #832

Use mktempdir for temporary regridding directories, instead of using mkpath(path) and manually calling rm(path)

Content

  • use mktempdir for the regrid folder created in setup_output_dirs
  • use mktempdir for regrid dirs in regridder_tests.jl and regridder_mpi_tests.jl
  • remove mkpath(REGRID_DIR) call in Regridder
  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/mktempdir branch 3 times, most recently from b8c0015 to 7d84ce9 Compare September 28, 2024 01:09
@juliasloan25 juliasloan25 requested review from Sbozzolo and charleskawczynski and removed request for Sbozzolo September 28, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskawczynski charleskawczynski Awaiting requested review from charleskawczynski

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use mktempdir instead of mkpath/rm in tests
1 participant
@juliasloan25