Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GroupingAggregatedTransform for single-level aggregation. Add test. #10063

Merged
merged 3 commits into from
Apr 6, 2020

Conversation

KochetovNicolai
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix error Cannot clone block with columns because block has 0 columns ... While executing GroupingAggregatedTransform. It happened when setting distributed_aggregation_memory_efficient was enabled, and distributed query read aggregating data with different level from different shards (mixed single and two level aggregation).

Have decreased log level for StorageDistributed because otherwise test with cluster with default database fails.

Copy link
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix test and return log level to warning

@alesapin
Copy link
Member

alesapin commented Apr 6, 2020

Can be merged according to previous tests run.

@alesapin alesapin merged commit 107c5b7 into master Apr 6, 2020
@alesapin alesapin deleted the fix-GroupingAggregatedTransform-single-level branch April 6, 2020 19:13
KochetovNicolai pushed a commit that referenced this pull request Apr 7, 2020
…form-single-level

Fix GroupingAggregatedTransform for single-level aggregation. Add test.

(cherry picked from commit 107c5b7)
KochetovNicolai pushed a commit that referenced this pull request Apr 7, 2020
…form-single-level

Fix GroupingAggregatedTransform for single-level aggregation. Add test.

(cherry picked from commit 107c5b7)
@KochetovNicolai KochetovNicolai added pr-bugfix Pull request with bugfix, not backported by default no-docs-needed v20.1 labels Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-docs-needed pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants