Fix very rare race condition in ThreadPool #11314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually it's OOM on CI machine (false message). |
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix very rare race condition in ThreadPool (cherry picked from commit 1df5c28)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix very rare race condition in ThreadPool (cherry picked from commit 1df5c28)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix very rare race condition in ThreadPool (cherry picked from commit 1df5c28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix very rare race condition in ThreadPool.
Detailed description / Documentation draft:
It was introduced in #9154. The reason it that we access
exceptionobject without locking mutex. At the same time, exception may be rethrown in another thread, then catched by non-const reference and modified. See link. Found here: #11301