-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ORCBlockOutputFormat #11662
Add ORCBlockOutputFormat #11662
Conversation
I forgot to add include path in cmake, I'l add it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write more comments and add performance test (just include ORC format into existing tests of formats).
number_orc_column->notNull[i] = 0; | ||
continue; | ||
} | ||
if constexpr (std::is_same<NumberType, UInt8>::value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is dirty hack :) Please write comment about this special case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it doesn't work https://clickhouse-builds.s3.yandex.net/11662/717f63923a19b9a4b0932e6295ed60d3753e7009/build_log_707272824_1592914485.txt
Maybe add Int8
to if statement?
src/CMakeLists.txt
Outdated
@@ -364,6 +364,12 @@ target_include_directories (clickhouse_common_io SYSTEM BEFORE PUBLIC ${DOUBLE_C | |||
|
|||
target_include_directories (clickhouse_common_io SYSTEM BEFORE PUBLIC ${MSGPACK_INCLUDE_DIR}) | |||
|
|||
target_include_directories (clickhouse_common_io SYSTEM BEFORE PUBLIC ${ORC_INCLUDE_DIR}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe better to write it under if (USE_ORC)
statement?
} | ||
|
||
template <typename ColumnType, typename GetSecondsFunc, typename GetNanosecondsFunc> | ||
void ORCBlockOutputFormat::ORCBlockOutputFormat::writeDateTimes( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double ORCBlockOutputFormat::ORCBlockOutputFormat
?
@nikitamikhaylov can you help? I can't understand what is wrong with Functional stateless tests (unbundled) and Performance test. They don't see ORC output format. |
I will help, of course. But there is another strange error with clang-tidy build... Which I don’t know how to fix. |
Tests |
Build failure is caused by internal CI problem. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add ORCBlockOutputFormat
Detailed description / Documentation draft:
ORC output format
This output format writes data in orc format.