Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative user_files_path #7632

Merged
merged 5 commits into from
Dec 6, 2019
Merged

Conversation

hczhcz
Copy link
Contributor

@hczhcz hczhcz commented Nov 5, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Improvement

Short description (up to few sentences):

Allow relative user_files_path (in the way similar to format_schema_path)

@alexey-milovidov
Copy link
Member

Could you please also add an integration test?

some_data = "\t111.222\nData\t333.444"

node.exec_in_container(['bash', '-c', 'echo "{}{}" > {}'.format(
filename,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test doesn't work:
NameError: global name 'filename' is not defined

Please, merge master into your branch before fixing it (now you can see Integration tests — failed:0, passed:0, error:0, it's because integration tests was broken in master)

@hczhcz hczhcz force-pushed the patch-2 branch 3 times, most recently from 442028a to 95b9d8e Compare December 4, 2019 00:04
@alexey-milovidov alexey-milovidov merged commit 3d27949 into ClickHouse:master Dec 6, 2019
@hczhcz hczhcz deleted the patch-2 branch December 9, 2019 09:34
@KochetovNicolai KochetovNicolai added the pr-improvement Pull request with some product improvements label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants