Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More languages for regions #8189

Merged
merged 1 commit into from
Dec 15, 2019
Merged

More languages for regions #8189

merged 1 commit into from
Dec 15, 2019

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • New Feature

Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Support more languages in embedded dictionary for region names: 'ru', 'en', 'ua', 'uk', 'by', 'kz', 'tr', 'de', 'uz', 'lv', 'lt', 'et', 'pt', 'he', 'vi'.

Detailed description:
TODO: Add integration test. Support all languages.

@alexey-milovidov
Copy link
Member Author

This is very old code that is needed only for some internal customers.
It's better to avoid usage of embedded dictionary for region names because the same can be achieved with external dictionaries in more flexible way.

@alexey-milovidov alexey-milovidov merged commit 575984b into master Dec 15, 2019
@KochetovNicolai KochetovNicolai added the pr-feature Pull request with new product feature label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants